Skip to content

Regression tests for Rustup breakage tracking issue #3913 #3936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
flip1995 wants to merge 2 commits into from
Closed

Regression tests for Rustup breakage tracking issue #3913 #3936

flip1995 wants to merge 2 commits into from

Conversation

@flip1995
Copy link
Member

@flip1995 flip1995 commented Apr 10, 2019

cc #3913

Tests for the tracking issue. This commits can be cherry-picked for fixing these issues.

@flip1995 flip1995 mentioned this pull request Apr 10, 2019
Closed
3 tasks
@flip1995
Copy link
Member Author

flip1995 commented Apr 10, 2019

Failures: https://travis-ci.com/rust-lang/rust-clippy/jobs/191751335#L1226-L1538

Closing this PR to keep the queue clean. This can be reopened to rerun Travis.

@flip1995 flip1995 closed this Apr 10, 2019
@flip1995
Copy link
Member Author

flip1995 commented May 12, 2019

lets see if #4082 has fixed the identity conversion bug

@flip1995 flip1995 reopened this May 12, 2019
@flip1995
Copy link
Member Author

flip1995 commented May 12, 2019

Yes identity conversion is fixed!
https://travis-ci.com/rust-lang/rust-clippy/jobs/199515830#L1474-L1476

failures:
    [ui] ui/explicit_iter_loop_no_sugg.rs
    [ui] ui/into_iter_on_array_in_for_loop.rs

@flip1995 flip1995 closed this May 12, 2019
@flip1995 flip1995 mentioned this pull request May 12, 2019
Merged
@flip1995 flip1995 reopened this May 12, 2019
@flip1995 flip1995 force-pushed the test_rustup_breakage branch from fd13cb7 to 2420eab Compare May 12, 2019 19:34
@flip1995 flip1995 closed this May 12, 2019
bors added a commit that referenced this pull request May 12, 2019
@bors
Auto merge of #4089 - flip1995:id_conv_reg_test, r=Manishearth
c79838e 
Add regression test for identity_conversion FP

cc #3913 #4082 #3936

changelog: none
@flip1995
Copy link
Member Author

flip1995 commented Jun 14, 2019

I think 19e852c is also fixed.

@flip1995 flip1995 reopened this Jun 14, 2019
@flip1995
Copy link
Member Author

flip1995 commented Jun 14, 2019

Nice everything is fixed. The tests for this already exist in

rust-clippy/tests/ui/into_iter_on_ref.rs

Line 13 in bd39cea

for _ in [1, 2, 3].into_iter() {} //~ ERROR equivalent to .iter()

rust-clippy/tests/ui/into_iter_on_ref.stderr

Lines 1 to 6 in bd39cea

error: this .into_iter() call is equivalent to .iter() and will not move the array
--> $DIR/into_iter_on_ref.rs:13:24
|
LL | for _ in [1, 2, 3].into_iter() {} //~ ERROR equivalent to .iter()
| ^^^^^^^^^ help: call directly: `iter`
|

and

rust-clippy/tests/ui/for_loop.rs

Line 107 in bd39cea

for _v in vec.iter() {}

rust-clippy/tests/ui/for_loop.stderr

Lines 65 to 71 in bd39cea

error: it is more concise to loop over references to containers instead of using explicit iteration methods
--> $DIR/for_loop.rs:107:15
|
LL | for _v in vec.iter() {}
| ^^^^^^^^^^ help: to write this more concisely, try: `&vec`
|
= note: `-D clippy::explicit-iter-loop` implied by `-D warnings`

@flip1995 flip1995 closed this Jun 14, 2019
@flip1995 flip1995 deleted the test_rustup_breakage branch June 14, 2019 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@flip1995